kingamarton commented on a change in pull request #260:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/260#discussion_r644839585
##########
File path: pkg/shim/scheduler_test.go
##########
@@ -132,7 +132,7 @@ partitions:
// wait for scheduling app and tasks
// verify app state
- cluster.waitAndAssertApplicationState(t, appID,
events.States().Application.Failed)
+ cluster.waitAndAssertApplicationState(t, appID,
events.States().Application.Failing)
Review comment:
I don't think this fix is OK here. When the application is rejected by
the scheduler, the app should fail. Otherwise in this scenario, the app will
never Fail, it will stuck in the Failing state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
