manirajv06 commented on a change in pull request #260:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/260#discussion_r646140871
##########
File path: pkg/shim/scheduler_test.go
##########
@@ -132,7 +132,7 @@ partitions:
// wait for scheduling app and tasks
// verify app state
- cluster.waitAndAssertApplicationState(t, appID,
events.States().Application.Failed)
+ cluster.waitAndAssertApplicationState(t, appID,
events.States().Application.Failing)
Review comment:
Yes, correct. In case of app rejection, we should directly move the app
to 'Failed' state. Handled it using appropriate state transition, rejected ->
failed during fail application event. Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
