wilfred-s commented on a change in pull request #296:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/296#discussion_r688200846
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -142,15 +144,26 @@ func NewDynamicQueue(name string, leaf bool, parent
*Queue) (*Queue, error) {
if err != nil {
return nil, fmt.Errorf("dynamic queue creation failed: %s", err)
}
- // pull the properties from the parent that should be set on the child
- sq.setTemplateProperties(parent.getProperties())
+
+ sq.applyTemplate(lookupTemplate(parent))
sq.UpdateSortType()
log.Logger().Info("dynamic queue added to scheduler",
zap.String("queueName", sq.QueuePath))
return sq, nil
}
+// use input template to initialize properties, maxResource, and
guaranteedResource
+// only leaf queue can use template as the values from template is meaningful
to leaf only.
Review comment:
I agree please implement that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
