chia7712 commented on a change in pull request #296:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/296#discussion_r688266458
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -182,36 +195,86 @@ func (sq *Queue) mergeProperties(parent, config
map[string]string) {
}
}
-// Set the properties that the dynamic child queue inherits from the parent
-// The properties list for the parent must be retrieved using getProperties()
-// This currently only sets the sort policy as it is set on the parent
-// Further implementation is part of YUNIKORN-193
-// lock free call
-func (sq *Queue) setTemplateProperties(parent map[string]string) {
- if len(parent) == 0 {
- return
+// try to find a template from closet parent
+func lookupTemplate(sq *Queue) *template.Template {
Review comment:
> The REST info is not affected and we do not have to recursively look
for the template with the inheritance implemented as proposed in the
addChildQueue comments.
fair enough. will set the template when we add the queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
