chenya-zhang commented on a change in pull request #356:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/356#discussion_r781379822
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -827,13 +827,41 @@ func (sa *Application)
tryPlaceholderAllocate(nodeIterator func() NodeIterator,
if ph.released || request.taskGroupName !=
ph.taskGroupName {
continue
}
+ // before we check anything we need to check the
resources equality
+ delta := resources.Sub(ph.AllocatedResource,
request.AllocatedResource)
Review comment:
Maybe we could replace "ph" (placeholder) with "hold" (v.s. "request")
to make our codebase easier to understand. :) But if it appears in too many
places, it's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
