pbacsko commented on a change in pull request #370:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/370#discussion_r799469114
##########
File path: pkg/scheduler/objects/node.go
##########
@@ -49,6 +50,7 @@ type Node struct {
allocations map[string]*Allocation
schedulable bool
unlimited bool
+ ready bool
Review comment:
On this abstraction level, this field could have a different name like
`acceptingContainers` or just `healthy`.
We could possibley utilize this field for scheduling decisions:
https://kubernetes.io/docs/concepts/architecture/nodes/#condition
`Ready == true` -> "_if the node is healthy and ready to accept pods, False
if the node is not healthy and is not accepting pods, and Unknown if the node
controller has not heard from the node in the last node-monitor-grace-period
(default is 40 seconds)_"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
