wilfred-s commented on a change in pull request #370:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/370#discussion_r809711047
##########
File path: pkg/scheduler/context.go
##########
@@ -631,6 +635,23 @@ func (cc *ClusterContext) updateNode(nodeInfo
*si.NodeInfo) {
switch nodeInfo.Action {
case si.NodeInfo_UPDATE:
+ var newReadyStatus bool
+ var err error
+ if newReadyStatus, err =
strconv.ParseBool(nodeInfo.Attributes["ready"]); err != nil {
+ log.Logger().Error("Could not parse ready attribute,
assuming true", zap.Any("attributes", nodeInfo.Attributes))
+ newReadyStatus = true
Review comment:
Are we sure that we get this information from the k8shim?
Looking at what is send by the shim we seem to only get the resources and
some fixed rack related info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
