pbacsko commented on a change in pull request #362:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r799473141
##########
File path: pkg/cache/nodes.go
##########
@@ -212,6 +213,15 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode
*v1.Node) {
return
}
+ if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
+ schedulerNode.ready = common.HasReadyCondition(newNode)
Review comment:
Updating this field in `SchedulerNode` is probably not necessary, but
for the sake of consistency, I decided to do it anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
