wilfred-s commented on a change in pull request #362:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r813533391
##########
File path: pkg/cache/nodes.go
##########
@@ -212,6 +213,15 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode
*v1.Node) {
return
}
+ if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
+ schedulerNode.ready = common.HasReadyCondition(newNode)
Review comment:
I filed YUNIKORN-1091 for the broken nodesMap update.
We do need this update in the node. This change will clash with that fix.
I also logged YUNIKORN-1090 to remove the common.Node object. That change is
impacted by what we have here too.
Moving forward and leaving the fix up for the two new jiras.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
