pbacsko commented on a change in pull request #392:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/392#discussion_r832047633
##########
File path: test/e2e/framework/helpers/yunikorn/yk_utils.go
##########
@@ -19,34 +19,26 @@
package yunikorn
import (
- "errors"
"fmt"
- "regexp"
"github.com/apache/incubator-yunikorn-k8shim/test/e2e/framework/configmanager"
)
type ResourceUsage struct {
- memory string
- vCPU string
+ memory int64
+ vCPU int64
Review comment:
Really just a nit... do these have to be `int64`? Can't we just use
normal `int`?
##########
File path: test/e2e/framework/helpers/yunikorn/yk_utils.go
##########
@@ -19,34 +19,26 @@
package yunikorn
import (
- "errors"
"fmt"
- "regexp"
"github.com/apache/incubator-yunikorn-k8shim/test/e2e/framework/configmanager"
)
type ResourceUsage struct {
- memory string
- vCPU string
+ memory int64
+ vCPU int64
Review comment:
Really a nit... do these have to be `int64`? Can't we just use normal
`int`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]