craigcondit commented on a change in pull request #392:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/392#discussion_r832060758
##########
File path: test/e2e/framework/helpers/yunikorn/yk_utils.go
##########
@@ -19,34 +19,26 @@
package yunikorn
import (
- "errors"
"fmt"
- "regexp"
"github.com/apache/incubator-yunikorn-k8shim/test/e2e/framework/configmanager"
)
type ResourceUsage struct {
- memory string
- vCPU string
+ memory int64
+ vCPU int64
Review comment:
Yes they really do. Int only allows for 4 GB RAM for example. All
resources internally are mow 64-bit quantities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]