manirajv06 commented on code in PR #66: URL: https://github.com/apache/yunikorn-scheduler-interface/pull/66#discussion_r874869690
########## lib/go/Makefile: ########## @@ -51,6 +52,8 @@ PROTOGEN_ARCH := amd64 ifeq (i386,$(PROTOC_ARCH)) PROTOC_ARCH := x86_32 PROTOGEN_ARCH := 386 +else ifeq (arm64, $(PROTOC_ARCH)) +PROTOC_ARCH := x86_64 Review Comment: > protoc 3.20.1 and later support arm64 on Mac, and should be backwards compatible. Agreed but unfortunately corresponding version url for v3.16.0 (https://github.com/protocolbuffers/protobuf/releases/download/v3.16.0/) used to download has only protoc-3.16.0-osx-x86_64.zip not as we are expecting protoc-3.16.0-osx-aarch_64.zip. Where as, v3.20.1 releases has both zip for osx. Hence keeping x86_64 for protoc download. However, we should fix this in a generic way later as already there are open issues around version, grpc plugins etc as discussed in https://issues.apache.org/jira/browse/YUNIKORN-815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
