craigcondit commented on code in PR #66: URL: https://github.com/apache/yunikorn-scheduler-interface/pull/66#discussion_r874902106
########## lib/go/Makefile: ########## @@ -51,6 +52,8 @@ PROTOGEN_ARCH := amd64 ifeq (i386,$(PROTOC_ARCH)) PROTOC_ARCH := x86_32 PROTOGEN_ARCH := 386 +else ifeq (arm64, $(PROTOC_ARCH)) +PROTOC_ARCH := x86_64 Review Comment: protoc 3.20.1 produces identical Go output to 3.16.0 so there's no issue in using the newer version. I've verified this locally on linux/aarch_64. This doesn't change any runtime or compile-time dependencies for our code. Let's update the version to 3.20.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
