surahman opened a new pull request, #412:
URL: https://github.com/apache/yunikorn-core/pull/412
### What is this PR for?
The changes contained here allow for the configuration of the Health Check
interval as well as the ability to disable the health checks outright.
The format for the `ConfigMap` is as follows:
```yaml
scheduler:
heathcheck:
enabled: true
interval: 30s
partitions:
...
```
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [x] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [x] - Extend `Config` with a `HealthCheck` subsection under `Scheduler`.
* [x] - Extend `health_checker` to support custom intervals and disabling of
the health checks.
* [ ] - Extend `health_checker` with messages to indicate disabled health
checks. This is important so that a disabled health check is not confused with
a more serious issue.
* [ ] - Documentation updates.
### What is the Jira issue?
* [JIRA issue.](https://issues.apache.org/jira/browse/YUNIKORN-1213)
### How should this be tested?
Tests for all changes have been added to this PR. There is a need for
additional deployment testing.
### Questions:
* [ ] - How would we like to handle the functions which return health check
information? I can create an `isCheckEnabled` method that takes a
`*ClusterContext` and return a `bool` based on the settings in the configs. The
issue is that not all the methods take a `*ClusterContext` as a parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
