surahman commented on PR #412: URL: https://github.com/apache/yunikorn-core/pull/412#issuecomment-1132217702
I have examined all the functions for metrics generation in the `HealthCheck` and they are all called locally from the `runOnce` routine and the call tree that stems there. Given this, we can probably leave the routines as-is and add log messages at the `Warn` level to indicate that health metric reporting is disabled. There are also two methods that are exported and only ever called locally and I wonder if we can switch them to not be exported? https://github.com/apache/yunikorn-core/blob/aacdb887fb5ff02441d5c577d23698086d711f28/pkg/scheduler/health_checker.go#L129 https://github.com/apache/yunikorn-core/blob/aacdb887fb5ff02441d5c577d23698086d711f28/pkg/scheduler/health_checker.go#L146 What are your thoughts @yangwwei and @craigcondit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
