lixmgl commented on code in PR #429:
URL: https://github.com/apache/yunikorn-core/pull/429#discussion_r954318873
##########
pkg/scheduler/objects/queue.go:
##########
@@ -657,6 +660,9 @@ func (sq *Queue) addChildQueue(child *Queue) error {
if sq.IsDraining() {
return fmt.Errorf("cannot add a child queue when queue is
marked for deletion: %s", sq.QueuePath)
}
+ if sq.maxRunningApps != 0 && sq.maxRunningApps < child.maxRunningApps {
+ return fmt.Errorf("parent maxRunningApps must be larger than
child maxRunningApps")
+ }
Review Comment:
Can you point me where is other resources config validations check?
If you are referring this method:
https://github.com/apache/yunikorn-core/blob/branch-1.0/pkg/scheduler/objects/queue.go#L207
I don't think it's a good idea to add this child maxRunningApps check into
this method since we need to iterate each child.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
