lixmgl commented on code in PR #429:
URL: https://github.com/apache/yunikorn-core/pull/429#discussion_r959941574
##########
pkg/scheduler/objects/queue.go:
##########
@@ -657,6 +660,9 @@ func (sq *Queue) addChildQueue(child *Queue) error {
if sq.IsDraining() {
return fmt.Errorf("cannot add a child queue when queue is
marked for deletion: %s", sq.QueuePath)
}
+ if sq.maxRunningApps != 0 && sq.maxRunningApps < child.maxRunningApps {
+ return fmt.Errorf("parent maxRunningApps must be larger than
child maxRunningApps")
+ }
Review Comment:
Updated, added check into configValidator file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
