pbacsko commented on code in PR #429:
URL: https://github.com/apache/yunikorn-core/pull/429#discussion_r961046263
##########
pkg/scheduler/objects/utilities_test.go:
##########
@@ -49,11 +49,20 @@ func createManagedQueue(parentSQ *Queue, name string,
parent bool, maxRes map[st
// create managed queue with props set
func createManagedQueueWithProps(parentSQ *Queue, name string, parent bool,
maxRes, props map[string]string) (*Queue, error) {
+ return createManagedQueuePropsMaxApps(parentSQ, name, parent, maxRes,
props, uint64(0))
Review Comment:
Does `maxApps` have to be an `uint64`? I mean I understand that it's more
logical, but now we have these weird casts here and in line queue.go:1359.
Simple `int` is the most portable data type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
