pbacsko commented on code in PR #429:
URL: https://github.com/apache/yunikorn-core/pull/429#discussion_r979863391
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1292,3 +1304,67 @@ func (sq *Queue) String() string {
return fmt.Sprintf("{QueuePath: %s, State: %s, StateTime: %x,
MaxResource: %s}",
sq.QueuePath, sq.stateMachine.Current(), sq.stateTime,
sq.maxResource)
}
+
+func (sq *Queue) incRunningApps() {
+ if sq == nil {
+ return
+ }
+ if sq.parent != nil {
+ sq.parent.incRunningApps()
+ }
+ sq.internalIncRunningApps()
+}
+
+func (sq *Queue) internalIncRunningApps() {
+ sq.Lock()
+ defer sq.Unlock()
+ sq.runningApps++
+}
Review Comment:
@lixmgl I read the stackoverflow topic and that's related to goroutine
scheduling. If what you're saying is correct that would mean that sequantial
consistency is broken. What you're doing here is single threaded, meaning
everything runs on a single goroutine. To me it would be extremely suprirising
if merging `internalIncRunningApps()` into `incRunningApps()` would result in
incorrect behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
