craigcondit commented on code in PR #487: URL: https://github.com/apache/yunikorn-k8shim/pull/487#discussion_r1028742102
########## README.md: ########## @@ -71,12 +77,12 @@ You can set `DOCKER_ARCH`, `REGISTRY` and `VERSION` in the commandline to build ``` make image DOCKER_ARCH=amd64 REGISTRY=yunikorn VERSION=latest ``` -This command will build an amd64 binary executable with version `latest` and the docker image tag is `yunikorn/yunikorn:scheduler-latest`. If not specified, `DOCKER_ARCH` defaults to the build host's architecture. +This command will build an amd64 binary executable with version `latest` and the docker image tag is `yunikorn/yunikorn:scheduler-amd64-latest`. If not specified, `DOCKER_ARCH` defaults to the build host's architecture. Review Comment: Can we add some language reflecting that this is a architecture-specific tag? It will be different for arm, etc. ########## README.md: ########## @@ -46,6 +46,12 @@ Run `./k8s_yunikorn_scheduler -help` to see all options. In case you get an error relating to `checksum mismatch`, run `go clean -modcache` and then rerun `make build`. ### Build run + Review Comment: This is not a requirement to run YuniKorn. We should not put this section in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
