kannon92 commented on code in PR #487:
URL: https://github.com/apache/yunikorn-k8shim/pull/487#discussion_r1029756555
##########
README.md:
##########
@@ -71,12 +77,12 @@ You can set `DOCKER_ARCH`, `REGISTRY` and `VERSION` in the
commandline to build
```
make image DOCKER_ARCH=amd64 REGISTRY=yunikorn VERSION=latest
```
-This command will build an amd64 binary executable with version `latest` and
the docker image tag is `yunikorn/yunikorn:scheduler-latest`. If not specified,
`DOCKER_ARCH` defaults to the build host's architecture.
+This command will build an amd64 binary executable with version `latest` and
the docker image tag is `yunikorn/yunikorn:scheduler-amd64-latest`. If not
specified, `DOCKER_ARCH` defaults to the build host's architecture.
You can run following command to retrieve the meta info for a docker image
build, such as component revisions, date of the build, etc.
```
-docker inspect --format='{{.Config.Labels}}' yunikorn/yunikorn:scheduler-latest
+docker inspect --format='{{.Config.Labels}}'
yunikorn/yunikorn:scheduler-amd64-latest
Review Comment:
This may be a controversial change since you may have developers building
accross many different repos. Not exactly sure how to make this better.
I could set it to the most common OS for your developers and anyone else can
modify this locally. Open to suggestions on these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
