pbacsko commented on code in PR #465:
URL: https://github.com/apache/yunikorn-core/pull/465#discussion_r1039659816
##########
pkg/scheduler/ugm/manager_test.go:
##########
@@ -118,6 +124,11 @@ func TestAddRemoveUserAndGroups(t *testing.T) {
}
assert.Equal(t, 0, len(manager.GetUsersResources()), "userTrackers
count should be 0")
assert.Equal(t, 0, len(manager.GetGroupsResources()), "groupTrackers
count should be 0")
+
+ var nilUserTracker *UserTracker
+ var nilGroupTracker *GroupTracker
+ assert.Equal(t, nilUserTracker,
manager.GetUserResourcesByUserName(user.User), "userTracker for user:
"+user.User+" should be nil")
+ assert.Equal(t, nilGroupTracker,
manager.GetGroupResourcesByGroupName(user.Groups[0]), "groupTracker for group:
"+user.Groups[0]+" should be nil")
Review Comment:
I'd definitely prefer an explicit nil check here: `assert.Assert(t,
manager.GetUserResourcesByUserName(user.User) == nil)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
