zhuqi-lucas commented on code in PR #515:
URL: https://github.com/apache/yunikorn-core/pull/515#discussion_r1154068467
##########
pkg/common/configs/configvalidator.go:
##########
@@ -357,13 +357,32 @@ func checkLimit(limit Limit, currIdx int,
userWildCardIdx, groupWildCardIdx *int
}
// at least some resource should be not null
if limit.MaxApplications == 0 && resources.IsZero(limitResource) {
- return fmt.Errorf("invalid resource combination for limit names
'%s' all resource limits are null", limit.Users)
+ return fmt.Errorf("invalid resource combination for limit user
names '%s' groups %s all resource limits are null", limit.Users, limit.Groups)
Review Comment:
Good suggestion @mitdesai , thank you review!
##########
pkg/common/configs/configvalidator.go:
##########
@@ -357,13 +357,32 @@ func checkLimit(limit Limit, currIdx int,
userWildCardIdx, groupWildCardIdx *int
}
// at least some resource should be not null
if limit.MaxApplications == 0 && resources.IsZero(limitResource) {
- return fmt.Errorf("invalid resource combination for limit names
'%s' all resource limits are null", limit.Users)
+ return fmt.Errorf("invalid resource combination for limit user
names '%s' groups %s all resource limits are null", limit.Users, limit.Groups)
}
+
+ if queue.MaxApplications != 0 && (limit.MaxApplications >
queue.MaxApplications || limit.MaxApplications == 0) {
+ return fmt.Errorf("invalid MaxApplications settings for limit
user names '%s' groups %s exeecd current the queue MaxApplications",
limit.Users, limit.Groups)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
