0yukali0 commented on code in PR #515:
URL: https://github.com/apache/yunikorn-core/pull/515#discussion_r1161222629
##########
pkg/common/configs/configvalidator.go:
##########
@@ -357,13 +357,32 @@ func checkLimit(limit Limit, currIdx int,
userWildCardIdx, groupWildCardIdx *int
}
// at least some resource should be not null
if limit.MaxApplications == 0 && resources.IsZero(limitResource) {
- return fmt.Errorf("invalid resource combination for limit names
'%s' all resource limits are null", limit.Users)
+ return fmt.Errorf("invalid resource combination for limit %s
all resource limits are null", limit.Limit)
}
+
+ if queue.MaxApplications != 0 && (limit.MaxApplications >
queue.MaxApplications || limit.MaxApplications == 0) {
+ return fmt.Errorf("invalid MaxApplications settings for limit
%s exeecd current the queue MaxApplications", limit.Limit)
Review Comment:
No, the default value of MaxApplications in the limit is 0.
The message hints that admin should set the MaxApplications in the limit
when the MaxApplications in the queue is set.
Because users will not know that setting the MaxApplications in limit is
necessary after setting the MaxApplications in the queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
