craigcondit commented on PR #562: URL: https://github.com/apache/yunikorn-core/pull/562#issuecomment-1587601760
> I think storing `[]si.EventRecord` is preferable to `[]*si.EventRecord`. The only small issue is the map inside `si.Resource`, that must be copied manually. I think using pointers is fine. Since we need to return sublists for client paging, that's a lot of copies. We also aren't really going to get the benefit of CPU cache locality when we have to turn around and convert the lists to JSON for transmission anyway. Thinks like reversing and subslicing a list of pointers is going to be more efficient (as the actual data doesn't need to move) the smaller those lists are (and pointers are as small as they can get). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
