pbacsko commented on PR #562: URL: https://github.com/apache/yunikorn-core/pull/562#issuecomment-1587620086
> One other question. I don't see any locking here, is that going to be handled externally? I'm thinking about this one, we probably need it. We can insert this logic to various places, but there's no locking where it makes the most sense. I'll add it in the next iteration. > I don't think we need to store the ID per record. All we need is the ID of the head of the list. So on startup, headID = 0, and after 1k events, headID = 1000. Then you can infer the ID of any message by it's position within the buffer. Yep, that makes thing easier. But `EventRecord` still needs to be updated so it can be captured on the client side, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
