pbacsko commented on code in PR #571:
URL: https://github.com/apache/yunikorn-core/pull/571#discussion_r1232516214
##########
pkg/scheduler/objects/application.go:
##########
@@ -2009,3 +2017,20 @@ func (sa *Application)
SetTimedOutPlaceholder(taskGroupName string, timedOut int
sa.placeholderData[taskGroupName].TimedOut = timedOut
}
}
+
+func (sa *Application) SendTerminateAllocationAskEvent(allocKey string) {
Review Comment:
> It's not a good idea to check whether allocKey is empty in
Application.RemoveAllocationAsk and sent related events
Why? An empty string means that we cancel all asks. All we have to do is
iterate through `sa.requests` and send the related events. If we have 100 asks,
then so be it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
