pbacsko commented on code in PR #571:
URL: https://github.com/apache/yunikorn-core/pull/571#discussion_r1233710437
##########
pkg/scheduler/objects/application.go:
##########
@@ -2009,3 +2018,20 @@ func (sa *Application)
SetTimedOutPlaceholder(taskGroupName string, timedOut int
sa.placeholderData[taskGroupName].TimedOut = timedOut
}
}
+
+func (sa *Application) sendRemoveAskEvent(allocKey string) {
+ sa.RLock()
+ defer sa.RUnlock()
Review Comment:
This lock must be eliminated because the method is called from a locked call
site. If it's needed then you have to create another one without locks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
