pbacsko commented on code in PR #579:
URL: https://github.com/apache/yunikorn-core/pull/579#discussion_r1276095491
##########
pkg/events/event_ringbuffer.go:
##########
@@ -199,3 +199,41 @@ func newEventRingBuffer(capacity uint64) *eventRingBuffer {
events: make([]*si.EventRecord, capacity),
}
}
+
+// resize the existing ring buffer
+// this method will be called upon configuration reload
+func (e *eventRingBuffer) Resize(newSize uint64) {
Review Comment:
This definitely needs a unit test, with all branches being covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
