pbacsko commented on PR #579: URL: https://github.com/apache/yunikorn-core/pull/579#issuecomment-1632180155
> > Note that existing code (`node_events.go`, `application_events.go`) should be modified to check if the event system is enabled or not. Right now it's checking a boolean and the result never changes on config reload. I suppose that needs to be replaced to something like `events.GetEventSystem().IsEventSystemEnabled()`. > > I think we actually want that code enabled unconditionally -- we need to start passing those events to the shim to do things like map predicate failures to the pods which generated them so that we set our event status properly. Yes, it's true that we do have events that we always send out (REQUEST in particular). Anyway, `queue_events.go` got merged, so that needs changes too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
