pbacsko commented on code in PR #597:
URL: https://github.com/apache/yunikorn-core/pull/597#discussion_r1276352452
##########
pkg/scheduler/objects/application.go:
##########
@@ -1638,6 +1640,7 @@ func (sa *Application) addAllocationInternal(info
*Allocation) {
zap.Error(err))
}
}
+ sa.hasPlaceholderAlloc.Store(true)
Review Comment:
If there's no application with an active placeholder allocation, then we
don't have to call `tryPlaceholderAllocate()` because there's no placeholder to
replace. We have to use a counter for this. Obviously if this counter is >1
then we have to descend the hierarchy and see where can we can do a replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
