pbacsko commented on code in PR #597:
URL: https://github.com/apache/yunikorn-core/pull/597#discussion_r1276421343
##########
pkg/scheduler/objects/application.go:
##########
@@ -103,6 +104,7 @@ type Application struct {
stateLog []*StateLogEntry // state log for this
application
placeholderData map[string]*PlaceholderData // track placeholder
and gang related info
askMaxPriority int32 // highest priority
value of outstanding asks
+ hasPlaceholderAlloc atomic.Bool // Whether there is at
least one allocated placeholder (has to be atomic.Bool due to queue/app lock
ordering)
Review Comment:
Update: I used the new unit test to check performance, we really want to
avoid `GetCopyOfApps()`. That slows things down significantly. I believe we
still have a speedup because we avoid the actual sorting, but the speedup is
much smaller this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
