manirajv06 commented on PR #595: URL: https://github.com/apache/yunikorn-core/pull/595#issuecomment-1655042802
@FrankYang0529 Thanks for your contribution. I can see tests being repeated again. For example, https://github.com/apache/yunikorn-core/blob/89090713894b93e1dd35c4ed39ac0dbaa0ff63b3/pkg/common/configs/configvalidator_test.go#L652C22-L652C22 is duplicate of https://github.com/apache/yunikorn-core/commit/68a82820f0d7ff82f4d5d9b44629ae3660a184e1#diff-b51101ffb2b9d6516306e0b62bdc45428e951201eb6c4289b1c0247edccb0b6b. So please check whether test exists already. If already exists, see if you can add anymore on top of it to ensure it is more robust. Otherwise, create a new one. I looked at the first case and observed this repeatition. So please merge duplicate methods to improve further as you have might have added a new case which is not covered currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
