manirajv06 commented on PR #595: URL: https://github.com/apache/yunikorn-core/pull/595#issuecomment-1655355060
> > I can see tests being repeated again. For example, https://github.com/apache/yunikorn-core/blob/89090713894b93e1dd35c4ed39ac0dbaa0ff63b3/pkg/common/configs/configvalidator_test.go#L652C22-L652C22 is duplicate of [68a8282#diff-b51101ffb2b9d6516306e0b62bdc45428e951201eb6c4289b1c0247edccb0b6b](https://github.com/apache/yunikorn-core/commit/68a82820f0d7ff82f4d5d9b44629ae3660a184e1#diff-b51101ffb2b9d6516306e0b62bdc45428e951201eb6c4289b1c0247edccb0b6b). So please check whether test exists already. If already exists, see if you can add anymore on top of it to ensure it is more robust. Otherwise, create a new one. > > Hi @manirajv06, thanks for the review. If you think they are duplicated, why we still put the "Ensure leaf queue user/group limits are within parent queue user/group limits" case in the Jira description? > It is exhaustive list to ensure all cases has been captured. Scope has been defined very clearly to explain the intent of the jira. anyways, not a problem. > I think my test cases in `configvalidator_test.go` are at a lower level - a single function. And test cases like `TestGroupLimitsWithHierarchicalQueue` in `config_test.go` are at a higher level - an integrated function including loading config and validation. Ok, will go through in detail. Overall intention is to ensure we don't duplicate the effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
