manirajv06 opened a new pull request, #668: URL: https://github.com/apache/yunikorn-core/pull/668
### What is this PR for? Problem: When config has limits set only for group, its quota was not getting honoured. User belonging to the group are allowed to use more resources than the allowed limit. Besides fixing the issue, this pr also simplifies the "cleaning up old user/group limits resource usage when config changes" codepath by removing the unnecessary clean up processing for the queue path. For example, say group "test" limit is set for queue path a.b.c. A config change had happened for the removal of "test" from a.b.c. So, clean up is required only when a.b.c queue path comes. But, clean up happens even when we are processing a & b from queue configs just because those queues has been tracked for the group "test". So far, as long as the queue has been tracked for a group, then, even that queue enters the clean up loop. which is not needed and correct. Now simplified the whole codepath by comparing the old config with the new config. If new config doesn't have the limit set for group "test", then clean up triggers. ### What type of PR is it? * [ ] - Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-2012 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
