manirajv06 commented on PR #668: URL: https://github.com/apache/yunikorn-core/pull/668#issuecomment-1773757004
Notes: Instead of locking objects for longer duration, moved the locks to the nearest place so that scheduler performance doesn't degrade during config changes. Changed the whole approach of clearing old configs by storing the new configs in separate maps and do the clearance only comparing the existing configs with new configs. For the newer limit configs, things happen while during the traversal and storing in new configs itself. Once all the work is over, replace the existing configs with new configs by keeping the write lock. This way, mostly read lock happens on the existing configs and write lock only during the final switch over. In addition, some more hidden issues has been identified and fixed them too. 1. When group limits removed in new config (root.parent.leaf) and contains the same group config in another level (root.parent), during the clearance step, we reduce/reset the resource usage for the entire group queue hierarchy (root.parent.leaf). i.e for root.parent though it has same group limit configs. 2. Changes in unlinking queue trackers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
