Haser0305 opened a new pull request, #671:
URL: https://github.com/apache/yunikorn-core/pull/671

   ### What is this PR for?
   Identuty config fields not set explicitly. 
   
   I have added a struct called `DefaultValues` to keep track of the fields 
that the user has not entered. 
   The function `CheckAndSetDefault` is used to determine if the value inside 
this field matches the predefined default value. 
   If it does, the field name will be added to `DefaultValues.defaultFields`, 
and the value of this field will be overwritten with the corresponding default 
value of its data type. 
   
   In the default settings, `uint64` is set to the maximum value of `uint64`, 
and `string` is set to `"defaultStringValue"`. 
   I did not handle operations for map, slice, etc. because if the user does 
not provide any input, it will be nil.
   
   To enable the above functionality, an `UnmarshalYAML` method has been 
implemented for each object that includes the `DefaultValues` struct. 
   
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [x] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1987
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - Not sure if setting uint64 default value to the maximum is 
appropriate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to