Haser0305 commented on PR #671:
URL: https://github.com/apache/yunikorn-core/pull/671#issuecomment-1782837811
> Eg. what's this `UnmarshalYAML(func(interface{}) error)` stuff? How is
this called? Does it implement an interface so it becomes a callback?
Yes, the Unmarshaler interface is used in the package yaml, which we used
for decoding the configuration. It allows customization of the behavior during
unmarshaling from a YAML document. In this case, it detects the default value,
then records the field name into an additional field (DefaultValues) and
updates the value.
If we don't need to distinguish between the not set and the null value, I
think there is indeed no need to add this code.
Thank you for taking the time to review my pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
