makinyemi opened a new pull request, #703: URL: https://github.com/apache/yunikorn-core/pull/703
### What is this PR for? Resolve gocritic lint issue: 1) commentFormatting: put a space between `//` 2) exitAfterDefer: log.Fatalf will exit, and `defer cancel()` will not run 3) use strings.ReplaceAll method in `strings.Replace(name, configs.DOT, configs.DotReplace, -1)` ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [ ] - Hot Fix * [x] - Refactoring ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-2126 ### How should this be tested? I tested this locally with make test, but noticed there are no test for this package (2) ### Screenshots (if appropriate) n/a ### Questions: n/a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
