pbacsko commented on code in PR #703:
URL: https://github.com/apache/yunikorn-core/pull/703#discussion_r1390547191
##########
cmd/schedulerclient/client.go:
##########
@@ -35,6 +36,12 @@ const (
)
func main() {
+ if err := mainNoExit(); err != nil {
+ log.Fatalf("error: %v", err)
+ }
+}
+
+func mainNoExit() error {
Review Comment:
Nit: can we give this a different name, like `runApp()`? This sounds weird.
##########
cmd/schedulerclient/client.go:
##########
@@ -69,9 +76,9 @@ func main() {
log.Print("Send request")
time.Sleep(time.Millisecond * 100)
}
- //if err := stream.CloseSend(); err != nil {
+ // if err := stream.CloseSend(); err != nil {
// log.Println(err)
- //}
+ // }
Review Comment:
This is unnecessary code, just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
