brandboat opened a new pull request, #151:
URL: https://github.com/apache/yunikorn-web/pull/151

   ### What is this PR for?
   Update karma-jasmine to version 5.1.0. Remove the dependency on ng-bullet 
since it is causing an error, as indicated in [this 
link](https://github.com/topnotch48/ng-bullet-workspace/blob/4cb3b2a3bfaf0d47277dcaabe4bd76b0062ce11c/projects/ng-bullet/src/testing.ts#L23-L26).
 Moreover, ng-bullet hasn't been updated for approximately 5 years. Some users 
have [reported the 
issue](https://github.com/topnotch48/ng-bullet-workspace/issues/38), and there 
is a [pull request](https://github.com/topnotch48/ng-bullet-workspace/pull/39) 
attempting to address it, but it hasn't been merged into ng-bullet yet. The 
purpose of ng-bullet is to [reduce the overall test execution 
time](https://github.com/topnotch48/ng-bullet-workspace/blob/master/projects/ng-bullet/README.md).
 However, after removing ng-bullet, I didn't observe a significant increase in 
test time (17.51s -> 18.44s).
   
   ### What type of PR is it?
   * [x] - Improvement
   
   ### Todos
   N/A
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-2081
   
   ### How should this be tested?
   covered by unit tests
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to