pbacsko commented on code in PR #740:
URL: https://github.com/apache/yunikorn-core/pull/740#discussion_r1407983468
##########
pkg/scheduler/objects/allocation.go:
##########
@@ -92,7 +92,7 @@ func NewAllocation(uuid, nodeID string, ask *AllocationAsk)
*Allocation {
bindTime: time.Now(),
nodeID: nodeID,
partitionName:
common.GetPartitionNameWithoutClusterID(ask.GetPartitionName()),
- uuid: uuid,
+ uuid: ask.allocationKey + "-" +
strconv.Itoa(ask.completedPendingAsk()),
Review Comment:
Nit: it's no longer an "uuid". If renaming generates too much change, then
just add a short comment that "it's no longer uuid, but the variable name is
kept" or sth similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
