wilfred-s commented on code in PR #740:
URL: https://github.com/apache/yunikorn-core/pull/740#discussion_r1410334191
##########
pkg/scheduler/objects/allocation.go:
##########
@@ -152,7 +154,9 @@ func NewAllocationFromSI(alloc *si.Allocation) *Allocation {
createTime: time.Unix(creationTime, 0),
allocLog: make(map[string]*AllocationLogEntry),
}
- return NewAllocation(alloc.UUID, alloc.NodeID, ask)
+ newAlloc := NewAllocation(alloc.NodeID, ask)
+ newAlloc.uuid = alloc.UUID
+ return newAlloc
Review Comment:
Please file a follow up jira on this as we need to properly handle this
case. However we need to wait until we have the initialisation code done on the
shim side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
