laysfire commented on code in PR #750:
URL: https://github.com/apache/yunikorn-core/pull/750#discussion_r1419879447
##########
pkg/scheduler/partition.go:
##########
@@ -425,6 +425,10 @@ func (pc *PartitionContext) removeAppInternal(appID
string) *objects.Application
return app
}
+func (pc *PartitionContext) GetApplication(appID string) *objects.Application {
+ return pc.getApplication(appID)
+}
Review Comment:
Hi, pbacsko, thanks for you reivew. There are RLock/RUnlock call in
getApplication function.
It seems that RWMutex is not reentrant. Adding RLock/RUnlock in
GetApplication may lead deadlock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
