laysfire commented on code in PR #750:
URL: https://github.com/apache/yunikorn-core/pull/750#discussion_r1425033856
##########
pkg/scheduler/partition.go:
##########
@@ -425,6 +425,10 @@ func (pc *PartitionContext) removeAppInternal(appID
string) *objects.Application
return app
}
+func (pc *PartitionContext) GetApplication(appID string) *objects.Application {
Review Comment:
hi @chia7712 thanks for review.
The are so many places call the internal method.
Which way do you think is better?
First,
- Add RLock/RUnlock in exposed method & Remove RLock/RUnlock in internal
method
- Add explicit RLock/RUnlock snippet in every place that call the internal
method
Second,
Just change the exposed name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
