chenyulin0719 commented on code in PR #146:
URL: https://github.com/apache/yunikorn-web/pull/146#discussion_r1423571148
##########
src/app/services/scheduler/scheduler.service.ts:
##########
@@ -328,13 +328,13 @@ export class SchedulerService {
const formatted = [];
if (resource && resource.memory !== undefined) {
- formatted.push(`Memory: ${CommonUtil.formatBytes(resource.memory)}`);
+ formatted.push(`Memory:
${CommonUtil.formatMemoryBytes(resource.memory)}`);
} else {
formatted.push(`Memory: ${NOT_AVAILABLE}`);
}
if (resource && resource.vcore !== undefined) {
- formatted.push(`CPU: ${CommonUtil.formatCount(resource.vcore)}`);
+ formatted.push(`CPU: ${CommonUtil.formatCpuCore(resource.vcore)}`);
Review Comment:
Hi @wilfred-s,
There have 2 other metrics are always showing `memory` and `cpu` too.
Both are calling formatPercent() in scheduler.service.ts
1. 'Absolute Used Capacity' in queue
2. 'Utilized' in node
For example, when 'memory'=7%, 'vcore'='19%', pod='1%', the result only show
'Memory' and 'Cpu' there.
**Example(Queue)**:
<img width="841" alt="image"
src="https://github.com/apache/yunikorn-web/assets/26764036/ca9c8d92-af30-457e-a8d2-b012efd9f540";>
<img width="342" alt="image"
src="https://github.com/apache/yunikorn-web/assets/26764036/70e7e16d-c20f-446b-b140-815151231672";>
**When no 'memory', 'vcore' in resources:**
<img width="335" alt="image"
src="https://github.com/apache/yunikorn-web/assets/26764036/1b62552d-4ec5-441d-bfde-db330584f126";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
