chenyulin0719 commented on code in PR #146:
URL: https://github.com/apache/yunikorn-web/pull/146#discussion_r1423581996
##########
src/app/services/scheduler/scheduler.service.ts:
##########
@@ -328,13 +328,13 @@ export class SchedulerService {
const formatted = [];
if (resource && resource.memory !== undefined) {
- formatted.push(`Memory: ${CommonUtil.formatBytes(resource.memory)}`);
+ formatted.push(`Memory:
${CommonUtil.formatMemoryBytes(resource.memory)}`);
} else {
formatted.push(`Memory: ${NOT_AVAILABLE}`);
}
if (resource && resource.vcore !== undefined) {
- formatted.push(`CPU: ${CommonUtil.formatCount(resource.vcore)}`);
+ formatted.push(`CPU: ${CommonUtil.formatCpuCore(resource.vcore)}`);
Review Comment:
Update new commit: bf35c02e4206ce0027a00ff6448f2e17673c30ed
I just follow the same logic to handle no keys in resources. (return 'n/a'
only )
Didn't expose more resource type in formatPercent() becasue I'm not sure if
it's better to have,
(If requried I can add a new commit or create another jira to fix it.)
**Before**:
<img width="345" alt="image"
src="https://github.com/apache/yunikorn-web/assets/26764036/0ca27b84-39cb-4798-a0b3-98a14aa39567";>
**After**:
<img width="335" alt="image"
src="https://github.com/apache/yunikorn-web/assets/26764036/2240ea3b-06e1-4779-b55a-0b586d1cb410";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
