laysfire commented on code in PR #750:
URL: https://github.com/apache/yunikorn-core/pull/750#discussion_r1425139419
##########
pkg/webservice/handlers.go:
##########
@@ -619,6 +625,57 @@ func getQueueApplications(w http.ResponseWriter, r
*http.Request) {
}
}
+func getPartitionApplicationIDsByState(w http.ResponseWriter, r *http.Request)
{
+ writeHeaders(w)
+ vars := httprouter.ParamsFromContext(r.Context())
+ if vars == nil {
+ buildJSONErrorResponse(w, MissingParamsName,
http.StatusBadRequest)
+ return
+ }
+ partition := vars.ByName("partition")
+ appState := vars.ByName("state")
+
+ partitionContext :=
schedulerContext.GetPartitionWithoutClusterID(partition)
+ if partitionContext == nil {
+ buildJSONErrorResponse(w, PartitionDoesNotExists,
http.StatusNotFound)
+ return
+ }
+ if !allowedAppStates[appState] {
+ buildJSONErrorResponse(w, "Application state is not allowed:
"+appState, http.StatusBadRequest)
+ return
+ }
+ appIDs := partitionContext.GetAppIDsByState(appState)
Review Comment:
For the Rejected applications, they were stored in rejectedApplications map.
And the get function is getRejectedAppsByState(). Same for completed
application.
Should we place the judge logic in handlers.go or partition.go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
