pbacsko commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1426852033
##########
pkg/webservice/handlers.go:
##########
@@ -614,6 +616,33 @@ func getQueueApplications(w http.ResponseWriter, r
*http.Request) {
appsDao = append(appsDao, getApplicationDAO(app))
}
+ if strings.Contains(r.Header.Get("Accept-Encoding"), "gzip") {
Review Comment:
1. Test is missing
2. Pls extract all headers to a `const` section, it's better for
maintainability. We have string literals all over the place, eg.
`writeHeaders()`. I don't think we need to import a separate library for this,
but at least have a single place where all of them are defined. Also do the
same for MIME types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
