wilfred-s commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1519003046
##########
pkg/webservice/handlers.go:
##########
@@ -746,6 +752,11 @@ func getQueueApplications(w http.ResponseWriter, r
*http.Request) {
appsDao = append(appsDao, getApplicationDAO(app))
}
+ if checkHeader(r.Header, "Content-Encoding", "gzip") {
Review Comment:
That is exactly why I would make the two functions so we can easily apply it
to any REST end points. Anything that sends more than a single IP packet as the
response can benefit.
For the streaming API, which uses really small messages that fit in a single
IP packet, compressing might be more overhead than the gains we get so that one
might not be a candidate everything else is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
